Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests running while world has not loaded #7379

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Jan 3, 2025

Description

Makes tests run when the first chunk can be retrieved in the world, ensuring the world is loaded before the tests run.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. unit testing For issues/PRs related to the Skript unit testing system. labels Jan 3, 2025
@Moderocky
Copy link
Member

image Uh oh 😬

@sovdeeth
Copy link
Member

sovdeeth commented Jan 3, 2025

You'll need to get a non-spawn chunk. Everything is fine in the spawn chunks

@Efnilite Efnilite requested review from sovdeeth and Moderocky January 3, 2025 23:53
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, ran the tests 2 extra times to double check

@cheeezburga cheeezburga added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jan 9, 2025
@Moderocky Moderocky merged commit 1f64752 into SkriptLang:dev/feature Jan 9, 2025
5 checks passed
@Efnilite Efnilite deleted the fix-test-time branch January 14, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. unit testing For issues/PRs related to the Skript unit testing system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants