Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tree types to prevent EvtGrow causing errors. #7230

Merged
merged 3 commits into from
Dec 1, 2024

Conversation

sovdeeth
Copy link
Member

Description

Also adds a test to catch this in the future.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Nov 25, 2024
@ShaneBeee
Copy link
Contributor

while you’re in here, might as well update the missing trees?
https://github.com/SkriptLang/Skript/blob/dev/patch/src/main/java/ch/njol/skript/util/StructureType.java

# -- Tree Types --

@sovdeeth
Copy link
Member Author

while you’re in here, might as well update the missing trees? https://github.com/SkriptLang/Skript/blob/dev/patch/src/main/java/ch/njol/skript/util/StructureType.java

# -- Tree Types --

tbh didn't remember those existed lol

@Moderocky Moderocky added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Nov 30, 2024
@APickledWalrus
Copy link
Member

The StructureType class will be updated in a future PR.

@APickledWalrus APickledWalrus merged commit b163e26 into SkriptLang:dev/patch Dec 1, 2024
7 checks passed
Burbulinis pushed a commit to Burbulinis/Skript that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants