-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed command tab complete not scanning softlink folders #7186
Open
killertuling
wants to merge
15
commits into
SkriptLang:dev/feature
Choose a base branch
from
Minecraft-FirTwon-Server:master
base: dev/feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixed command tab complete not scanning softlink folders #7186
killertuling
wants to merge
15
commits into
SkriptLang:dev/feature
from
Minecraft-FirTwon-Server:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, it will not be accessed
killertuling
changed the title
Fixed when using tab complet, if the target is a Linux softlink folde…
Fixed tab complet not scan softlink folder
Nov 3, 2024
Efnilite
requested changes
Nov 3, 2024
Co-authored-by: Efnilite <[email protected]>
Romitou
added
the
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
label
Nov 3, 2024
Efnilite
approved these changes
Nov 3, 2024
…ptLang#7188) Fix ExprTimeStates not accepting plural expressions
sovdeeth
approved these changes
Nov 5, 2024
* SoundUtils - handle Sound class for enum/interface * SoundUtils - fix an error with MC 1.15 * EffPlaySound.sk - add simple test to make sure syntax doesn't throw error * EffPlaySound - remove reflection and remove to effect class * EffPlaySound - some changes * EffPlaySound.sk - fix tests failing
Efnilite
added
the
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
label
Nov 12, 2024
Efnilite
changed the title
Fixed tab complet not scan softlink folder
Fixed command tab complete not scanning softlink folders
Nov 12, 2024
* catch long overflows * don't compromise with precision uses Math.xExact code to catch overflows instead of relying on doubles. * Apply suggestions from code review Co-authored-by: Efnilite <[email protected]> --------- Co-authored-by: Efnilite <[email protected]>
* handle invalid regex patterns * missing space in toString Co-authored-by: Efnilite <[email protected]> --------- Co-authored-by: Efnilite <[email protected]> Co-authored-by: sovdee <[email protected]>
fix turkish.lang Co-authored-by: sovdee <[email protected]>
* require skull texture lookup on paper servers * 1.19.4+
…r method for changing expressions. (SkriptLang#7120) * changeInPlace, fix indices being overwritten, regr tests * can't count * requested changes * Apply suggestions from code review Co-authored-by: Patrick Miller <[email protected]> --------- Co-authored-by: Patrick Miller <[email protected]>
branch needs to be updated before this can be merged |
Caused by height clamping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r, it will not be accessed
Description
Fixed where tab complet would not scan for .sk files within symlinked directories under the scripts folder.
This PR resolves the problem of not being able to scan these directories.
I have tested it, and after the modification, symlinked directories can be accessed normally.
The operating system I used is Ubuntu Server 24.04.
Target Minecraft Versions: any
Requirements: none
Related Issues: none