Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex replacement #7167

Merged
merged 41 commits into from
Dec 18, 2024
Merged

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Oct 29, 2024

Description

Continues #4323.

  • Addressed review requests
  • Added tests

Thanks @AyhamAl-Ali!


Target Minecraft Versions: any
Requirements: none
Related Issues: #6547

AyhamAl-Ali and others added 29 commits September 7, 2021 03:21
- Add regex replace first
- removed unused vars
# Conflicts:
#	src/main/java/ch/njol/skript/effects/EffReplace.java
@Efnilite Efnilite requested a review from sovdeeth October 29, 2024 15:19
@Efnilite Efnilite mentioned this pull request Oct 29, 2024
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/effects/EffReplace.sk Outdated Show resolved Hide resolved
@Efnilite Efnilite requested a review from sovdeeth November 16, 2024 11:13
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Nov 23, 2024
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more complex merge conflicts, it'd be best if you handled them

@sovdeeth sovdeeth removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 15, 2024
# Conflicts:
#	src/main/java/ch/njol/skript/effects/EffReplace.java
@Efnilite Efnilite requested a review from sovdeeth December 16, 2024 17:06
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 16, 2024
@Efnilite Efnilite requested a review from sovdeeth December 17, 2024 09:09
@sovdeeth sovdeeth added the 2.10 Targeting a 2.10.X version release label Dec 17, 2024
@Moderocky Moderocky merged commit 7c01138 into SkriptLang:dev/feature Dec 18, 2024
5 checks passed
@Efnilite Efnilite deleted the regex-replace branch December 22, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.10 Targeting a 2.10.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants