ExprDurability/ExprMaxDurability - account for custom durability #6803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneBeee
changed the title
sovdeeth
added
enhancement
sovdeeth
approved these changes
Jun 29, 2024
Pikachu920
approved these changes
Jun 30, 2024
sovdeeth
added
the
feature-ready
APickledWalrus
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix an issue with max durability of an item.
This expression was relying on the vanilla max durability of an item.
In Minecraft 1.20.5+ there is now the option of having custom durability on an item.
This PR also adds a changer to max durability expression allowing to change in Minecraft 1.20.5+
There is one TODO (waiting on Skript to update to Paper 1.21 API - #6798 )
Target Minecraft Versions: mainly 1.20.5+
Requirements: none
Related Issues: none