Add Timespan/Timespan=Number arithmetic and TimePeriod.MILLISECOND #6749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
enhancement
UnderscoreTud
approved these changes
Jun 1, 2024
Moderocky
approved these changes
Jun 1, 2024
Co-authored-by: _tud <[email protected]>
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to divide two timespans to get a number (units cancel). This makes doing math with timespans much easier:
Want to round to the nearest minute?
round({_ts} / 1 minute) * 1 minute. I suppose this can also be done with the timespan details expression, but I think this is a bit more natural.Added the TimePeriod.MILLISECONDS enum to replace Timespan#getMilliseconds(), but I'm not sure how appropriate this is. Opinions welcome.
Target Minecraft Versions: any
Requirements: none
Related Issues: none