Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor updates: plotting functions, exp correction #11

Closed
wants to merge 2 commits into from

Conversation

n-leo
Copy link
Collaborator

@n-leo n-leo commented Feb 23, 2024

  • functions to plot the stream files
  • exponential correction of dwell time with growth height

exponential correction of dwell time with growth height
@n-leo
Copy link
Collaborator Author

n-leo commented Feb 23, 2024

Alternatively, for the expoential correction intead of the proposed code changes, the ipython notebook examples should be updated to use the HeightCorrectionModel class instead of the old function [which I now have done].

The plot function would be good to accept in the code (I do not find it in the current commit); it can be helpful to plot an already saved stream file to check for the layout etc.

image

image

Included proper functions for exponential height correction model
@Skoricius
Copy link
Owner

Skoricius commented Mar 14, 2024

Thanks @n-leo! Before I review the PR, can you make sure it passes all the automatic tests? It currently fails formatting, so you need to run formatting by doing black f3ast and isort f3ast. That's going to fix formatting inconsistencies and reduce the diff with the current code.

@Skoricius
Copy link
Owner

Inactive for 3 months. I've added the essentials bits of this in the main code and closing now.

@Skoricius Skoricius closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants