Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Source: MangaIro #447

Merged
merged 84 commits into from
Oct 1, 2023
Merged

Conversation

getBoolean
Copy link
Contributor

@getBoolean getBoolean commented Sep 5, 2023

Checklist:

  • Updated source's version for individual source changes
  • Updated all sources' versions for template changes
  • Set appropriate nsfw value
  • Did not change id even if a source's name or language were changed
  • Tested the modifications by running it on the simulator or a test device

Note: Filters do not work with search
Homepage: https://w.mangairo.com/home

Closes #332

@getBoolean
Copy link
Contributor Author

Thanks for the thorough review! I especially appreciate the small tips you gave that might otherwise have been overlooked by others.

I've addressed all the feedback comments, but I'd like you to take a look at the fixes to make sure I addressed them properly.

@getBoolean
Copy link
Contributor Author

I scaled down that icon you linked to 128x128 from 512x512. The app currently only supports 128x128, correct?

src/rust/en.mangairo/res/settings.json Outdated Show resolved Hide resolved
src/rust/en.mangairo/res/source.json Outdated Show resolved Hide resolved
src/rust/en.mangairo/src/lib.rs Outdated Show resolved Hide resolved
src/rust/en.mangairo/src/parser.rs Outdated Show resolved Hide resolved
src/rust/en.mangairo/src/parser.rs Show resolved Hide resolved
src/rust/en.mangairo/src/parser.rs Outdated Show resolved Hide resolved
src/rust/en.mangairo/src/parser.rs Show resolved Hide resolved
src/rust/en.mangairo/src/parser.rs Outdated Show resolved Hide resolved
src/rust/en.mangairo/src/parser.rs Outdated Show resolved Hide resolved
src/rust/en.mangairo/src/parser.rs Outdated Show resolved Hide resolved
@Skittyblock
Copy link
Owner

I scaled down that icon you linked to 128x128 from 512x512. The app currently only supports 128x128, correct?

the app supports anything, but we use 128x128 conventionally since that's the largest the source icon would ever need to be and it's best to be consistent.

src/rust/en.mangairo/src/lib.rs Outdated Show resolved Hide resolved
src/rust/en.mangairo/src/parser.rs Show resolved Hide resolved
src/rust/en.mangairo/res/source.json Outdated Show resolved Hide resolved
@Skittyblock Skittyblock merged commit 0595172 into Skittyblock:main Oct 1, 2023
2 checks passed
@getBoolean getBoolean deleted the source/mangairo branch October 1, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mangairo
2 participants