Skip to content

Commit

Permalink
Correct personal_sign param ordering
Browse files Browse the repository at this point in the history
[It has been brought to my attention](MetaMask/metamask-extension#1557) that this (and in turn MetaMask's) personal_sign param ordering is incorrect.

How did this happen? Was it [the lack of a standard RPC test suite?](ethereum/EIPs#217) was it just my mistake? I'll claim both.

The Wiki seems to be accurate in correcting us here, too:
https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal_sign
  • Loading branch information
danfinlay committed Jun 8, 2017
1 parent 818ed3f commit 63de21f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"net_version": [[], "S"],
"net_peerCount": [[], "Q"],
"net_listening": [[], "B"],
"personal_sign": [["D20", "D", "S"], "D", 2],
"personal_sign": [["D", "D20", "S"], "D", 2],
"personal_ecRecover": [["D", "D"], "D20", 2],
"eth_protocolVersion": [[], "S"],
"eth_syncing": [[], "Boolean|EthSyncing"],
Expand Down

0 comments on commit 63de21f

Please sign in to comment.