Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port GeoJSON #6

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Port GeoJSON #6

merged 4 commits into from
Jan 29, 2025

Conversation

stefannikolei
Copy link
Contributor

I ported GeoJSON into this lib and removed the check for 4 Coordinates.

With this we only got 17 failing tests (Rust test and JS tests - the additional rust testcases fail in the js lib...) and 31 GREEN

Do we want this lib in here or not? Its not really much magic behind it..

@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented Jan 29, 2025

I think we should copy the code as you have but we'll need to add a readme to the project folder saying where we got it. It's annoying they don't have a strict-mode toggle to turn off those warnings.

@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented Jan 29, 2025

Just renamed the main branch from master, you'll have to run this locally.

git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this now because I need it for benchmarking. I'll add the readme and attempt to do something about all the build warnings.

@JimBobSquarePants JimBobSquarePants merged commit 1dbfdea into SixLabors:main Jan 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants