This repository has been archived by the owner on Sep 8, 2022. It is now read-only.
[MIRROR] Fix for Corporate Benches and Chair deconstruction + Time to build for chairs #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r chairs (#7594) * Buncha chair fixes * Forgot the test benches there, whoops * fixess! * removed a decal off fland, whoops
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: BeeStation/BeeStation-Hornet#7594
About The Pull Request
This PR aim to fix some stuff I forgot to fix in the BeeStation/BeeStation-Hornet#7547, the fixes are related to the corporate bench returning a massive ERROR icon due to GAGs issues and fixed a bug that, if you moved while deconstructing any chair, it would override the deconstruction time.
Also made all the chairs to actually take time to build instead of being insta-build, since some chairs actually took time (see wooden chair) while the grand majority where an instant build.
Also I want to credit https://github.com/Imaginos16 (aka PositiveEntropy) from /tg/ for making the icon for the Wooden chairs icons and the armchair/Sofa icons, and I forgot to update the PR before being merged to credit you properly, apoligies!
Why It's Good For The Game
Fixes are good and also i forgot to actually credit someone, hopefully this will be good enough.
Testing Photographs and Procedure
Screenshots&Videos
No real screenshot to be put in, since it's a fix.Turns out Better put on a screen:
Changelog
🆑 PigeonVerde322, PositiveEntropy
add: FORGOT to credit PositiveEntropy for the Wooden chairs icons and the armchair/Sofa icons in the previous PR, apoligies!
add: Added time-to-build to all the chairs
add: Courtesy of para, now benches can be coloured
fix: fixed a bug that, if you moved while deconstructing any chair, it would override the deconstruction time
fix: fixed Corporate benches being broken, now they use a different system than GAGs, also courtesy of para, now benches padding can be coloured!
/:cl: