Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix - Flujos de trabajo - Evaluar valores vacíos en campos numéricos #8

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

enricsinergia
Copy link
Collaborator

Descripción

A la hora de evaluar el valor nulo en lasd condiciones de los flujos de trabajo, se ha visto que los campos de tipo texto o fecha se recuperan como "", sin embargo los campos numéricos se estaban seteando a NULL. A la hora de comprobar si un campo era NULL, la condición miraba si el campo estaba como "". Se ha cambiado esta condición para que si el tipo es numérico y tiene valor NULL se altere el valor previo a la condición a "", sin afectar el valor en el resto del código (sólo para la evaluación de la condición), de manera que no haya efectos colaterales.

Pruebas

  1. Crear flujo de trabajo, añadiendo una condición donde se requiera que un importe sea nulo
  2. Comprobar que tanto en ejecucion "on save" como en el planificador, se ejecuta el flujo cuando y sólo cuando el campo numérico es NULL.

@enricsinergia enricsinergia self-assigned this Jan 2, 2024
@jalbaiges jalbaiges changed the title Null for decimals patched Hotfix - Flujos de trabajo - Evaluar valores vacíos en campos numéricos Jan 5, 2024
@enricsinergia enricsinergia reopened this Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

Actions executed at: 2024-01-18 08:26:57.

jordiSTIC
jordiSTIC previously approved these changes Jan 12, 2024
Copy link
Collaborator

@jordiSTIC jordiSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)Probado:

  • Código revisado.
  • Ejecución de Flujo de Trabajo con condición "is null" en campo Currency (al modificar y en planificador)

@AlbertoSTIC AlbertoSTIC requested review from PaulaaSTIC and removed request for AlbertoSTIC January 17, 2024 11:16
Copy link
Collaborator

@PaulaaSTIC PaulaaSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)probado

Copy link
Collaborator

@jordiSTIC jordiSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)Probado

@AlbertoSTIC AlbertoSTIC merged commit 395381e into develop Jan 18, 2024
1 check passed
@AlbertoSTIC AlbertoSTIC deleted the bug/WorkflowsDecimalNull branch January 18, 2024 08:26
@enricsinergia
Copy link
Collaborator Author

salesagility#10331

PaulaaSTIC pushed a commit that referenced this pull request Feb 26, 2024
# This is the 1st commit message:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #2:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #3:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #4:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #5:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #6:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #7:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #8:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #9:

Fix salesagility#10364 - Adding now option in Datetime fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incidencia - Flujos de trabajo - Error al evaluar condición en tipo decimal
4 participants