Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement - Acciones de Github - Adaptar Github Actions #7

Merged
merged 9 commits into from
Jan 3, 2024
Merged

Improvement - Acciones de Github - Adaptar Github Actions #7

merged 9 commits into from
Jan 3, 2024

Conversation

AlbertoSTIC
Copy link
Collaborator

@AlbertoSTIC AlbertoSTIC commented Jan 2, 2024 •
edited
Loading

Este PR adapta las Acciones de Github para que funcionen con el nuevo repositorio público.

Modificaciones realizadas:

  • Se añaden los secretos correspondientes en este repositorio
  • Se modifica la formula que recoge el nombre de la rama para que funcione en el contexto de ejecutar la acción manualmente
  • Se renombran algunas acciones
  • Se añade una acción para ejecutar ejecutar la reinstalación de la instancia a través de un botón (esto solo se puede probar una vez la acción llegue a la rama master)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024 •
edited
Loading

Actions executed at: 2024-01-03 11:13:05.

@AlbertoSTIC AlbertoSTIC changed the title Improvement - Acctiones de Github - Adaptar Github Actions a repositorio Improvement - Acciones de Github - Adaptar Github Actions a repositorio Jan 2, 2024
@AlbertoSTIC AlbertoSTIC closed this Jan 2, 2024
@AlbertoSTIC AlbertoSTIC reopened this Jan 2, 2024
@AlbertoSTIC AlbertoSTIC self-assigned this Jan 2, 2024
@AlbertoSTIC AlbertoSTIC added Improvement ... that do not affect user functionality Development Changes for development purposes labels Jan 2, 2024
enricsinergia
enricsinergia previously approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@enricsinergia enricsinergia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A)provado

No he podido verificar la parte de los secrets porqué no tengo acceso.
El cambio de manera de obtener el nombre de la rama, parece correcto (he hecho pruebas en un repo mío derivado de SuiteCRM también y parece funcionar).

@juanSTIC juanSTIC closed this Jan 3, 2024
@juanSTIC juanSTIC reopened this Jan 3, 2024
@juanSTIC juanSTIC force-pushed the improvement/ghActions branch from 1cda811 to 2358ce0 Compare January 3, 2024 10:52
juanSTIC
juanSTIC approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@juanSTIC juanSTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visto y ok.

@enricsinergia enricsinergia self-requested a review January 3, 2024 11:08
@AlbertoSTIC AlbertoSTIC changed the title Improvement - Acciones de Github - Adaptar Github Actions a repositorio Improvement - Acciones de Github - Adaptar Github Actions Jan 3, 2024
@AlbertoSTIC AlbertoSTIC merged commit 2f06c92 into develop Jan 3, 2024
6 of 7 checks passed
@AlbertoSTIC AlbertoSTIC deleted the improvement/ghActions branch January 3, 2024 11:12
@AlbertoSTIC AlbertoSTIC mentioned this pull request Jan 8, 2024
Merged
PaulaaSTIC pushed a commit that referenced this pull request Feb 26, 2024
@SinergiaCRM
# This is a combination of 9 commits.
d298e16 
# This is the 1st commit message:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #2:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #3:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #4:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #5:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #6:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #7:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #8:

Fix salesagility#10364 - Adding now option in Datetime fields

# This is the commit message #9:

Fix salesagility#10364 - Adding now option in Datetime fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricsinergia enricsinergia enricsinergia approved these changes

@juanSTIC juanSTIC juanSTIC approved these changes

Assignees

@AlbertoSTIC AlbertoSTIC

Labels
Development Changes for development purposes Improvement ... that do not affect user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlbertoSTIC @juanSTIC @enricsinergia