Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement - Validación de importación - Eliminar validación innecesaria del proceso de validación de importación #511

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Improvement - Validación de importación - Eliminar validación innecesaria del proceso de validación de importación #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions modules/stic_Import_Validation/ImporterValidationFunctions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ function identificationNumberValidation($module, $rowValue, $row)
// since in $row we have the label and not the key
global $app_list_strings;
$identification_types_list = $app_list_strings['stic_contacts_identification_types_list'];
$existLabel = false;
// $existLabel = false;
foreach ($identification_types_list as $key => $value) {
if (!empty($value) && in_array($value, $row)){
$existLabel = true;
// $existLabel = true;
// If the stic_identification_type_c field is mapped and its value is NIF or NIE
if ($value == $identification_types_list['nif'] || $value == $identification_types_list['nie']) {
return SticUtils::isValidNIForNIE($rowValue) ? $rowValue : 'LBL_ERROR_INVALID_IDENTIFICATION_NUMBER';
Expand All @@ -51,10 +51,14 @@ function identificationNumberValidation($module, $rowValue, $row)
}
}
}

// This validation is cancelled because the CRM has a LH that calculates the Identification Type in case this field is not informed and the Identification Number field is.
// More information at:
// If there is no label, it means that the Identification type field has not been mapped
if (!$existLabel) {
return 'LBL_ERROR_INVALID_IDENTIFICATION_NUMBER_MISSING_TYPE_FIELD';
}
// if (!$existLabel) {
// return 'LBL_ERROR_INVALID_IDENTIFICATION_NUMBER_MISSING_TYPE_FIELD';
// }
return true;
break;

default:
Expand Down
Loading