Hotfix - Formularios - Eliminar mensajes de error innecesarios

modules/stic_Web_Forms/Catcher/Donation/DonationBO.php

@@ -148,6 +148,7 @@ public function checkParams()
         $requiredParams = $this->requiredFormFields;
 
         // Define those required based on the target module.
+        $this->formParams['stic_identification_number_c'] = trim($this->formParams['stic_identification_number_c']);
         switch ($this->defParams['web_module']) {
             case 'Contacts':
                 $moduleRequiredFields = array('last_name', 'stic_identification_number_c');

modules/stic_Web_Forms/Catcher/Donation/DonationController.php

@@ -141,7 +141,7 @@ protected function doAction()
                     }
                 } // If it is an immediate operation the notification is automatically sent
                 else if (!$mailer->sendUserMail($defParams['decodedDefParams']['email_template_id'], $objWeb, $payment)) {
-                    $GLOBALS['log']->error('Line ' . __LINE__ . ': ' . __METHOD__ . ":  Unable to send confirmation email to user.");
+                    $GLOBALS['log']->warn('Line ' . __LINE__ . ': ' . __METHOD__ . ":  Unable to send confirmation email to user.");
                 }
             }
         }

modules/stic_Web_Forms/Catcher/Donation/DonationMailer.php

@@ -251,6 +251,11 @@ public function sendUserMail($templateId, $objWeb, $payment, $lang = null)
             return false;
         }
 
+        if (empty($templateId)) {
+            $GLOBALS['log']->warn('Line ' . __LINE__ . ': ' . __METHOD__ . ":  No template ID received.");
+            return false;
+        }
+
         // Add the recipient
         $GLOBALS['log']->debug('Line ' . __LINE__ . ': ' . __METHOD__ . ":  Adding recipient [{$objWeb->email1}] ...");
         $this->addMailsDest($objWeb->email1);

modules/stic_Web_Forms/Catcher/EventInscription/EventInscriptionBO.php

@@ -272,6 +272,7 @@ public function checkParams()
 
         if ($_REQUEST["validate_identification_number"] == '1') {
             // If identification type is not set or it is a NIF/NIE, validate it. In other case, don't validate
+            $this->formParams['Contacts___stic_identification_number_c'] = trim($this->formParams['Contacts___stic_identification_number_c']);
             if ($this->formParams['Contacts___stic_identification_number_c']
                 && (empty($this->formParams['Contacts___stic_identification_type_c'])
                     || $this->formParams['Contacts___stic_identification_type_c'] == 'nif'
@@ -283,6 +284,7 @@ public function checkParams()
             }
 
             // If organization's id is available, validate it
+            $this->formParams['Accounts___stic_identification_number_c'] = trim($this->formParams['Accounts___stic_identification_number_c']);
             if (!empty($this->formParams['Accounts___stic_identification_number_c']) &&
                 !self::checkTaxIdentity($this->formParams['Accounts___stic_identification_number_c'])) {
                 $GLOBALS['log']->error('Line ' . __LINE__ . ': ' . __METHOD__ . ":  The organization ID [{$this->formParams['Accounts___stic_identification_number_c']}] is not valid.");

modules/stic_Web_Forms/Catcher/EventInscription/EventInscriptionController.php

@@ -200,7 +200,7 @@ protected function sendMails($status)
         } else { // Otherwise, send the emails immediately
             $GLOBALS['log']->debug('Line ' . __LINE__ . ': ' . __METHOD__ . ":  Sending mail to the registered user...");
             if (!$mailer->sendUserMail($defParams['email_template_id'])) {
-                $GLOBALS['log']->error('Line ' . __LINE__ . ': ' . __METHOD__ . ":  Unable to send the email to the user.");
+                $GLOBALS['log']->warn('Line ' . __LINE__ . ': ' . __METHOD__ . ":  Unable to send the email to the user.");
             }
         }
     }

modules/stic_Web_Forms/Catcher/EventInscription/EventInscriptionMailer.php

@@ -193,6 +193,10 @@ protected function __sendUserMail($templateId, $objContactWeb, $event, $inscript
             $GLOBALS['log']->error('Line ' . __LINE__ . ': ' . __METHOD__ . ":  The data received does not include user email, notification cannot be sent.");
             return false;
         }
+        if (empty($templateId)) {
+            $GLOBALS['log']->warn('Line ' . __LINE__ . ': ' . __METHOD__ . ":  No templateId present.");
+            return false;
+        }
 
         // Añade el destinatario
         $GLOBALS['log']->debug('Line ' . __LINE__ . ': ' . __METHOD__ . ":  Adding recipient [{$objContactWeb->email1}] ...");

modules/stic_Web_Forms/Catcher/Include/Mailer/WebFormMailer.php

@@ -238,14 +238,14 @@ public function send()
                 $indice++;
             }
         } else {
-            LoggerManager::getLogger()->fatal('Attachements not found');
+            LoggerManager::getLogger()->warn('Attachements not found');
         }
         ////    END ATTACHMENTS
         ///////////////////////////////////////////////////////////////////////
 
         $GLOBALS['log']->debug('Line ' . __LINE__ . ': ' . __METHOD__ . ":  Sending mail...");
         if (!$mail->Send()) {
-            $GLOBALS['log']->error('Line ' . __LINE__ . ': ' . __METHOD__ . ":  There was an error sending the mail.");
+            $GLOBALS['log']->warn('Line ' . __LINE__ . ': ' . __METHOD__ . ":  There was an error sending the mail.");
             return false;
         }
         return true;