Hotfix - Plantillas PDF - Formatear número con las preferencias del usuario #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actions executed at: 2024-11-19 15:31:27. |
AlbertoSTIC
requested review from
jordiSTIC
and removed request for
AlbertoSTIC
jordiSTIC
reviewed
Oct 28, 2024
SticInclude/Utils.php
Outdated
| $dec_sep = empty($user_dec_sep) ? $sugar_config['default_decimal_seperator'] : $user_dec_sep; | ||
| $grp_sep = empty($user_grp_sep) ? $sugar_config['default_number_grouping_seperator'] : $user_grp_sep; | ||
| $sig_digits = empty($user_sig_digits) ? $sugar_config['sigDigits'] : $user_sig_digits; |
There was a problem hiding this comment.
El nombre correcto de la configuración debería ser default_currency_significant_digits: en config.php, se define en $sugar_config:
Line 267 in b96498d
jordiSTIC
requested changes
Oct 28, 2024
PaulaaSTIC
approved these changes
Nov 6, 2024
|
PR en SA: salesagility#10598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Como se describe en el issue, se ha comprobado que en un campo de tipo decimal, no mostraba el separador de miles al generar una plantilla PDF. Debería reflejar el formato de número tal como se muestra en el CRM, donde sí aparece el separador de miles en las vistas.
Se ha implementado en la función que formatea el número decimal con las preferencias que tiene el usuario, o están por defecto, de los separadores y el número de decimales que se quiere mostrar con la función number_format()
How To Test This