[FEATURE] [MER-3873] Likert activity for instructors #5274
Merged
+1,296
−1,469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w ActivityHelpers
darrensiegel
requested changes
Dec 2, 2024
|
|
||
| def get_activities(assessment_resource_id, section_id, student_ids, filter_by_survey \\ false), | ||
| do: | ||
| Core.get_evaluated_activities_for( |
There was a problem hiding this comment.
This is a really nice isolation of redundant code that had been spread across Practice, Summative and Survey views. But we really should be taking this opportunity to move away from querying across ActivityAttempt and ResourceAttempt tables. Instead, this information can be much more efficiently retrieved by querying across Summary tables and then joining to the corresponding SectionResource record (through section id and resource id) to get the title of the resource.
There was a problem hiding this comment.
I filed https://eliterate.atlassian.net/browse/MER-4066 for this future work.
darrensiegel
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the ticket
Different likert activities (with different amount of questions and options, even different text length for the options) rendered correctly in :
Screen.Recording.2024-11-29.at.2.58.40.PM.mov
This PR sets the ground for rendering light/dark Vegalite Visualizations that react to changes made by the user in the mode selected ("dark", "light", "auto"). Changes can be seen on
assets/src/components/misc/VegaLiteRenderer.tsxSome refactoring
While working on this feature I found that three tabs (Scored Activities, Practice Activities and Surveys) from the Insights instructor view had duplicated code. So, this PR exctracts common logic of those 3 live_component modules (OliWeb.Components.Delivery.{PracticeActivities, ScoredActivities, Surveys}) into a new
OliWeb.Delivery.ActivityHelpersmodule.And some ecto queries from that migrated code where moved to their corresponding context module as well (
Oli.Analytics.SummaryandOli.Delivery.Attempts.Core)