Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "not" and "hasCompletedQuest" conditions #2

Merged
merged 3 commits into from
Aug 12, 2019

Conversation

AlbertoRota
Copy link
Contributor

No description provided.

@Silverfeelin
Copy link
Owner

Silverfeelin commented Aug 6, 2019

Thanks for your contribution. The code looks good to me.

Please note that the Quickbar is a subset of sb.StardustSuite, meaning changes made to this repository should also be made to StardustLib. This repository isn't a fork due to the amount of unrelated content in the main repository. Instead, changes related to the Quickbar are mirrored.

Here's the file in the original repository:
https://github.com/zetaPRIME/sb.StardustSuite/blob/master/StardustLib/sys/stardust/quickbar/conditions.lua
If you could apply the changes there and submit a PR I'll make sure the changes are included in the next Quickbar Mini release both on GitHub and Steam. It seems that the Quickbar is a commit behind StardustLib so I will fix this later today (#3).

Fix reserved not declaration. Preserve parameters.
@Silverfeelin Silverfeelin self-assigned this Aug 6, 2019
@AlbertoRota
Copy link
Contributor Author

PR created here:
zetaPRIME/sb.StardustSuite#11

@Silverfeelin
Copy link
Owner

I went ahead and mirrored the changes from StardustLib. Could you update the PR for the new structure? I'd do it myself but don't want to take credit for copying your changes over. Sorry for the inconvenience!

@AlbertoRota
Copy link
Contributor Author

I'm going to be away from my laptop for a few days, feel absolutely free to do the needed changes, I'm doing this because I wanted to help, not for fame, so no problem there ;)

@Silverfeelin Silverfeelin merged commit d1410c6 into Silverfeelin:master Aug 12, 2019
Silverfeelin added a commit that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants