#1445: Code improvement Gloss Detail context variables #1454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared context for Public and Logged In views consolidated
The (original context variable names)
context[topic+'_fields']
where topic is in['phonology', 'semantics', 'main']
have been streamlined.
But the filling in the context is left in the spin-off branch for public so it is clear which fields are being omitted for public view, instead of burying this inside a new, shared called function with a "is_public" extra parameter to distnguish the two branches in the code.
Because the Edit branch needs additional context. This has been split off into separate code in order to make the "topics" code more concise. Specifically, the "choice lists" that used to be inside of this code are now in a separate new function. The used to be nested inside the original "topics" loop. Now this is in a separate function that yields a nested dictionary.