Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code in get_context_data in GlossDetailView #1445

Open
susanodd opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1454
Open

Improve code in get_context_data in GlossDetailView #1445

susanodd opened this issue Dec 19, 2024 · 0 comments · May be fixed by #1454

Comments

@susanodd
Copy link
Collaborator

susanodd commented Dec 19, 2024

As part of Public View in #1419 #1403, a template has been created dictionary/gloss.html and well as a new python file for the context variables that are shared and used in both views, context_data_gloss.py

The phonology code that is originally used and some of the code only used by the original template dictionary/gloss_detail.html has not yet been cleaned up.

Improve the Phonology "loop" and separate the choice lists (used in Edit functionality) out of the loop so the shared functionality can be moved to the Python file context_data_gloss.py and shared.

Do the remaining code cleanup here.

@susanodd susanodd self-assigned this Dec 19, 2024
susanodd added a commit that referenced this issue Jan 11, 2025
Shared context for Public and Logged In views consolidated
@susanodd susanodd linked a pull request Jan 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant