fix: ignore static AIS data for self if configured in sk #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkurki
reviewed
Nov 25, 2024
| ToSignalK.prototype.filterSelfAISStatic = function (values) { | ||
| return values.filter((kv) => { | ||
| return ( | ||
| kv.path !== '' && |
There was a problem hiding this comment.
How is this supposed to work considering that n2k-signalk outputs deltas using the empty path trick? https://github.com/SignalK/n2k-signalk/blob/3b0401af0738c3fd8097ac661e060cdf4b9296cc/test/129794_ais_class_a_static_data.js#L59-L77
There was a problem hiding this comment.
It's currently just ignoring that data for self.
There was a problem hiding this comment.
The baseDeltas check does nothing if (did not check..) all the static data from AIS has path: ''. Or am I missing something?
|
Good question. I am not sure. Will check... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently overwrite things like name, design.length, etc.
Ignore them incase AIS is wrong.