-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: ubuntu 24.04 and node22 for docker image #1826
feature: ubuntu 24.04 and node22 for docker image #1826
Conversation
I think we should consider this as a whole: upgrade the recommended version, instructions, include v22 (and drop v16) in test runs etc. I am not very eager to upgrade just version in the docker image so that what we recommend and what is in the image are not matching. But nice to know that things are working! |
Agree. Opened this just to prepare things to upgrade. Maybe we should consider parallel test image using this instead of changing current setup. At least until more testing and good understanding about impacts. |
A separate tagged docker image is a great idea! |
Now ready for first review
|
To be honest I am a little lost as to what changes and what the practical end result is going to be. Think about it as a regular user running sk on docker: how can they understand what is happening, what’s in it for them and how do we envision to continue from here. The PR will be linked to release notes, so the description plays a role. And should the docs be updated? |
My intetion is/was to bring these new background technologies to wider testing. Target for active developers, not kind of end-users. Thinking other options and I came to alternative idea. Lets not merge this to master, but e.g. same name branch that I have. Triggering changed to manual and GA could be triggered whenever seen beneficial, not every commit. Developers could test stuff against this and give feedback. Then setup would get broader audience and test penetration without messing master. |
I'll close this PR and open two new ones.
|
Content
Upgrades to two major components for docker images
I know this is big change and will need lot of further testing.
Notes:
Default user
ubuntu:x:1000:
remove and replaced withnode:x:1000:
Reserved groups in Ubuntu 24.04.
node:x:1000: systemd-journal:x:999: systemd-network:x:998: systemd-timesync:x:997: input:x:996: sgx:x:995: kvm:x:994: render:x:993: systemd-resolve:x:992:
Therefore old
docker
,i2c
andspi
groups need to be changed.Testing
Some
DeprecationWarning
will appear with this upgrade, but that is more or less expected.So far tested in
amd64
andarm64
platforms without finding breaking changes.