Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: ubuntu 24.04 and node22 for docker image #1826

Closed

Conversation

KEGustafsson
Copy link
Contributor

Content
Upgrades to two major components for docker images

  • Ubuntu 24.04 LTS base image
  • Node upgrade from 20.x LTS to 22.x LTS

I know this is big change and will need lot of further testing.

Notes:
Default user ubuntu:x:1000: remove and replaced with node:x:1000:
Reserved groups in Ubuntu 24.04.
node:x:1000: systemd-journal:x:999: systemd-network:x:998: systemd-timesync:x:997: input:x:996: sgx:x:995: kvm:x:994: render:x:993: systemd-resolve:x:992:
Therefore old docker, i2c and spi groups need to be changed.

Testing
Some DeprecationWarning will appear with this upgrade, but that is more or less expected.
So far tested in amd64 and arm64 platforms without finding breaking changes.

@tkurki
Copy link
Member

tkurki commented Nov 4, 2024

I think we should consider this as a whole: upgrade the recommended version, instructions, include v22 (and drop v16) in test runs etc. I am not very eager to upgrade just version in the docker image so that what we recommend and what is in the image are not matching.

But nice to know that things are working!

@tkurki tkurki added the feature label Nov 4, 2024
@KEGustafsson
Copy link
Contributor Author

Agree. Opened this just to prepare things to upgrade.

Maybe we should consider parallel test image using this instead of changing current setup. At least until more testing and good understanding about impacts.

@tkurki
Copy link
Member

tkurki commented Nov 5, 2024

A separate tagged docker image is a great idea!

@KEGustafsson KEGustafsson marked this pull request as ready for review November 13, 2024 09:27
@KEGustafsson
Copy link
Contributor Author

KEGustafsson commented Nov 13, 2024

Now ready for first review

  • base images for Ubuntu 24.04 and Node22.x build automatically once per week
  • docker builds on these base images triggered same way as previously
  • new SK docker images have -test tag added
  • SK started with node --trace-deprecation for better debugging

@tkurki
Copy link
Member

tkurki commented Dec 15, 2024

To be honest I am a little lost as to what changes and what the practical end result is going to be. Think about it as a regular user running sk on docker: how can they understand what is happening, what’s in it for them and how do we envision to continue from here. The PR will be linked to release notes, so the description plays a role.

And should the docs be updated?

@KEGustafsson
Copy link
Contributor Author

My intetion is/was to bring these new background technologies to wider testing. Target for active developers, not kind of end-users.

Thinking other options and I came to alternative idea. Lets not merge this to master, but e.g. same name branch that I have. Triggering changed to manual and GA could be triggered whenever seen beneficial, not every commit.

Developers could test stuff against this and give feedback.

Then setup would get broader audience and test penetration without messing master.

@KEGustafsson
Copy link
Contributor Author

I'll close this PR and open two new ones.

  1. Ubuntu 24.04 upgrade to base image
  2. Node22 upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants