ensure requests to apply decision include time (#51)

SiftScience · Jun 19, 2017 · 3f38f76 · 3f38f76
1 parent 07af653
commit 3f38f76
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/lib/sift/client/decision/apply_to.rb b/lib/sift/client/decision/apply_to.rb
@@ -9,7 +9,15 @@ module Sift
   class Client
     class Decision
       class ApplyTo
-        PROPERTIES = %w{ source analyst description order_id user_id account_id }
+        PROPERTIES = %w{
+          source
+          analyst
+          description
+          order_id
+          user_id
+          account_id
+          time
+        }
 
         attr_reader :decision_id, :configs, :getter, :api_key
 
@@ -57,7 +65,8 @@ def request_body
             source: source,
             description: description,
             analyst: analyst,
-            decision_id: decision_id
+            decision_id: decision_id,
+            time: time
           }
         end
 

diff --git a/spec/unit/client/decision/apply_to_spec.rb b/spec/unit/client/decision/apply_to_spec.rb
@@ -41,12 +41,19 @@ class Decision
               source: "manual",
               analyst: "[email protected]",
               description: "be blocking errrday allday",
-              decision: decision,
-              user_id: "user_1234"
+              user_id: "user_1234",
+              time: 1234,
+              fake_param: "this should not exist"
             }
 
             applier = ApplyTo.new(api_key, decision_id, configs)
-            request_body = MultiJson.dump(applier.send(:request_body))
+            request_body = MultiJson.dump({
+              source: configs[:source],
+              description: configs[:description],
+              analyst: configs[:analyst],
+              decision_id: decision_id,
+              time: 1234
+            })
 
             response_body = {
               "entity" => {