Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setPageName type + iOS no-op method #6

Open
jarredt opened this issue May 25, 2022 · 4 comments
Open

setPageName type + iOS no-op method #6

jarredt opened this issue May 25, 2022 · 4 comments

Comments

@jarredt
Copy link

jarredt commented May 25, 2022

The new setPageName method was not added to the Typescript types. Also, it would be ideal to add a no-op method for this on the iOS side, so that our own source code doesn't need to do platform-specific branching. Thanks!

@vincent-sift
Copy link
Contributor

Thanks @jarredt we are aware of this issue and we are working on adding a fix.

@mdole
Copy link

mdole commented Jul 14, 2023

Hey, we also use this package over at Artsy and would appreciate these changes as well! Are you accepting PRs from outside collaborators at the moment? If so, happy to throw one together

@richardkuiper
Copy link

Thanks @jarredt we are aware of this issue and we are working on adding a fix.

Hi @vincent-sift . Just checking if you are still working on this? Seems to be about a year and a half.

@viaskal-sift
Copy link
Contributor

viaskal-sift commented Apr 15, 2024

@mdole regarding

Are you accepting PRs from outside collaborators at the moment? If so, happy to throw one together

if you are still ready to raise a PR, feel free to do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants