-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setPageName
type + iOS no-op method
#6
Comments
Thanks @jarredt we are aware of this issue and we are working on adding a fix. |
Hey, we also use this package over at Artsy and would appreciate these changes as well! Are you accepting PRs from outside collaborators at the moment? If so, happy to throw one together |
Hi @vincent-sift . Just checking if you are still working on this? Seems to be about a year and a half. |
@mdole regarding
if you are still ready to raise a PR, feel free to do that |
The new
setPageName
method was not added to the Typescript types. Also, it would be ideal to add a no-op method for this on the iOS side, so that our own source code doesn't need to do platform-specific branching. Thanks!The text was updated successfully, but these errors were encountered: