webhook validation endpoint #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreejithKExalture
force-pushed
the
webhook_validation
branch
from
6431650 to
186d0cc
Compare
|
I was wondering knew what the use case of this validation utility is or if it's just a backlog item created by Brian Higgins who is no longer at the company? Additionally the ticket mentions that the relevant headers and the payload itself would be validated as well, but this only validates the Sift signature? |
|
@bho-sift I think its just to abstract the logic of header validation behind a method. This is a related thread that I could find: SiftScience/sift-python#73 |
|
Already added in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sift.atlassian.net/browse/MSUE-70