Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the "Umbrella header for module Sift cannot be found" #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dbarden
Copy link
Contributor

@dbarden dbarden commented Apr 8, 2024

Purpose

Creates a include header that will contain the headers that should be distributed. It has some symlinks to the headers that should be public.

Summary

This avoid copying all the headers and solves the compile time error shown in #114

Testing

Integrate the sift package via SPM and compile the project

Checklist

  • The change was thoroughly tested manually
  • The change was covered with unit tests
  • The change was tested with the integration example
  • Necessary changes were made in the integration example (if applicable)
  • New functionality is reflected in README (if applicable)

Creates a `include` header that will contain the headers that should be
distributed.

This avoid copying all the headers and solves the compile time error
shown in SiftScience#114
@viaskal-sift
Copy link
Contributor

@dbarden the issue should have been addressed already, should we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants