Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding $iata_carrier_code to the $booking complex field #76

Merged
merged 1 commit into from
Sep 26, 2024
Merged

adding $iata_carrier_code to the $booking complex field #76

merged 1 commit into from
Sep 26, 2024

Conversation

rsomavarapu-sift
Copy link
Contributor

@rsomavarapu-sift rsomavarapu-sift commented Sep 26, 2024 •
edited
Loading

Purpose

Adding support for $iata_carrier_code field for $booking complex field

Summary

Adding support for $iata_carrier_code field for $booking complex field to support new use-cases

Testing

  • Updated unit tests

Checklist

  • The change was thoroughly tested manually
  • The change was covered with unit tests
  • The change was tested with real API calls (if applicable)
  • Necessary changes were made in the integration tests (if applicable)
  • New functionality is reflected in README

@rsomavarapu-sift rsomavarapu-sift changed the title adding to the complex field adding $iata_carrier_code to the $booking complex field Sep 26, 2024
@rsomavarapu-sift rsomavarapu-sift force-pushed the add_iata_carrier_code_field branch from 16d7994 to e136f12 Compare September 26, 2024 06:11
ademianenko-sift
ademianenko-sift approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ademianenko-sift ademianenko-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sbogolii-sift
sbogolii-sift approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@sbogolii-sift sbogolii-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbogolii-sift sbogolii-sift merged commit d9154c5 into master Sep 26, 2024
2 checks passed
@sbogolii-sift sbogolii-sift deleted the add_iata_carrier_code_field branch September 26, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ademianenko-sift ademianenko-sift ademianenko-sift approved these changes

@sbogolii-sift sbogolii-sift sbogolii-sift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsomavarapu-sift @sbogolii-sift @ademianenko-sift