Jenkins CI to GH actions #112
Conversation
.github/workflows/ci.yml
Outdated
| build: | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: docker://fabernovel/android:api-29-v1.1.0 |
There was a problem hiding this comment.
Can you try using circleci image?
There was a problem hiding this comment.
@jlin-sift Per Github actions documentation above image was suggested for the android build.
There was a problem hiding this comment.
Based on https://github.com/SiftScience/sift-android/blob/master/sift/build.gradle#L15-L16, SdkVersion is 31, and buildToolsVersion is 30.0.0. It does not look like fabernovel/android:api-29-v1.1.0 has these versions. See https://hub.docker.com/layers/fabernovel/android/api-29-v1.1.0/images/sha256-10f45f7c3a75f7220d58bf24039f3f7ac492c42dd0ebf37f76fa6010fe595271?context=explore. You might want to try api-31-v1.6.0.
There was a problem hiding this comment.
Sure @jlin-sift Since it was the same version used in circleCI pipelineconfig i have added api-29-v1.1.0.
Let me update it to api-31-v1.6.0.
There was a problem hiding this comment.
@jlin-sift Latest build after above suggested update.
https://github.com/SiftScience/sift-android/actions/runs/9669426792/job/26675896118
.github/workflows/ci.yml
Outdated
| image: docker://fabernovel/android:api-29-v1.1.0 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: set up JDK 11 |
There was a problem hiding this comment.
Why do you need to install jdk11? Looks like fabernovel/android has Java?
.github/workflows/ci.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Grant execute permission for gradlew | ||
| run: chmod +x gradlew |
There was a problem hiding this comment.
Is this needed? Jenkins CI does not need this.
There was a problem hiding this comment.
Removed @jlin-sift
|
lgtm |
Purpose
Jenkins CI to GH actions
Summary
Jenkins CI to GH actions
Testing
test CI build for GH actions
Checklist