Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle plugin with upstream changes #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rravi-sift
Copy link

@rravi-sift rravi-sift commented Mar 14, 2023

Summary of change

  1. Checked out https://github.com/joelittlejohn/jsonschema2pojo/tree/master/jsonschema2pojo-gradle-plugin
  2. Copied the contents of jsonschema2pojo-gradle-plugin from the original repo to this repo
  3. Reverted the new parameter changes in JsonSchemaExtension that are not in this core library.
  4. Add mvn config to build fat jar in jsonschema2pojo-gradle-plugin
  5. Build fat jar
mvn package -Dmaven.test.skip
  1. Deploy the gradle plugin to the internal registry
mvn deploy:deploy-file -DgroupId=org.jsonschema2pojo -DartifactId=jsonschema2pojo-gradle-plugin \
  -Dversion=<version> \
  -Dpackaging=jar \
  -Dfile=<jar_location>-jar-with-dependencies.jar \
  -Durl=<repo>

@rravi-sift rravi-sift requested a review from a team March 16, 2023 06:42
@rravi-sift rravi-sift changed the title Update gradle plugin Update gradle plugin with upstream changes Mar 16, 2023
Copy link

@nicolesu nicolesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @rravi-sift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants