Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(renterd): split out uploads manager context #882

Merged
merged 1 commit into from
Jan 19, 2025
Merged

refactor(renterd): split out uploads manager context #882

merged 1 commit into from
Jan 19, 2025

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Jan 13, 2025 •
edited
Loading

  • This PR refactors out uploadManager as a distinct context, it was previously part of the files context. Originally this made sense but as the features have evolved it became convoluted. With all the other changes we now have four clear contexts related to files and uploads: filesManager, files, uploadsManager, and uploads.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: fff4002

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2025 8:17pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2025 8:17pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2025 8:17pm
hostd ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2025 8:17pm
website ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2025 8:17pm

@alexfreska alexfreska mentioned this pull request Jan 13, 2025
Merged
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Jan 13, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alexfreska alexfreska mentioned this pull request Jan 13, 2025
Merged
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from 5ec9f3b to dff1051 Compare January 13, 2025 18:37
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from 309c0d2 to 3ae8d4d Compare January 13, 2025 18:37
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from dff1051 to ed8c4d3 Compare January 13, 2025 18:45
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from 3ae8d4d to ee32ed0 Compare January 13, 2025 18:45
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from ed8c4d3 to 35b074f Compare January 13, 2025 18:59
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from ee32ed0 to 71c9279 Compare January 13, 2025 18:59
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from 35b074f to 5bb5595 Compare January 13, 2025 19:20
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from 71c9279 to 25ac4e6 Compare January 13, 2025 19:20
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from 5bb5595 to 9c4d57b Compare January 13, 2025 19:27
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from 25ac4e6 to 87002b8 Compare January 13, 2025 19:27
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from 9c4d57b to 713e839 Compare January 14, 2025 15:48
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from 87002b8 to fbf04c5 Compare January 14, 2025 15:48
This was referenced Jan 14, 2025
Merged
Merged
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from 713e839 to a786cbe Compare January 14, 2025 15:54
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from fbf04c5 to 04b0343 Compare January 14, 2025 15:54
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from a786cbe to 9bf941e Compare January 14, 2025 19:09
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from 04b0343 to 2f70447 Compare January 14, 2025 19:10
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from 9bf941e to 155eee5 Compare January 14, 2025 19:34
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from 155eee5 to e7b9586 Compare January 15, 2025 21:03
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from e5a0d07 to b4c9a84 Compare January 15, 2025 21:03
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from b4c9a84 to 110e062 Compare January 16, 2025 14:17
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from e7b9586 to 121de5e Compare January 16, 2025 15:51
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from 110e062 to 4f89344 Compare January 16, 2025 15:51
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from 121de5e to c21e840 Compare January 16, 2025 15:52
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from 4f89344 to 8d0d7f8 Compare January 16, 2025 15:52
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from c21e840 to 5843a16 Compare January 16, 2025 20:00
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from 8d0d7f8 to ed248a7 Compare January 16, 2025 20:01
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from 5843a16 to ecbd835 Compare January 19, 2025 01:34
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from ed248a7 to aed922c Compare January 19, 2025 01:34
@alexfreska alexfreska force-pushed the feat_renterd_uploads_list_local_and_remote branch from ecbd835 to 954724a Compare January 19, 2025 17:27
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from aed922c to a854027 Compare January 19, 2025 17:27
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Jan 19, 2025 •
edited
Loading

Merge activity

  • Jan 19, 2:55 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 19, 3:05 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 19, 3:05 PM EST: A user merged this pull request with Graphite.

@alexfreska alexfreska changed the base branch from feat_renterd_uploads_list_local_and_remote to graphite-base/882 January 19, 2025 20:01
@alexfreska alexfreska changed the base branch from graphite-base/882 to main January 19, 2025 20:03
@alexfreska alexfreska force-pushed the refactor_renterd_split_out_uploads_manager_context branch from a854027 to fff4002 Compare January 19, 2025 20:04
@alexfreska alexfreska merged commit 45fcbec into main Jan 19, 2025
8 of 33 checks passed
@alexfreska alexfreska deleted the refactor_renterd_split_out_uploads_manager_context branch January 19, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telestrial telestrial telestrial approved these changes

@peterjan peterjan Awaiting requested review from peterjan

Assignees

@alexfreska alexfreska

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfreska @telestrial