Rationalize search API HTTP error codes and add hosts and v2 contracts to search #161
+49
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris124567
changed the title
n8maninger
requested changes
Jan 19, 2025
| @@ -445,5 +449,19 @@ func (e *Explorer) Search(id types.Hash256) (SearchType, error) { | |||
| return SearchTypeContract, nil | |||
| } | |||
|
|
|||
| return SearchTypeInvalid, errors.New("no such element") | |||
| v2Contracts, err := e.V2Contracts([]types.FileContractID{types.FileContractID(id)}) | |||
There was a problem hiding this comment.
Good opportunity to clean this up by implementing it directly in the database. Will reduce IO since you're not loading data you're going to throw away and probably improve performance.
| return | ||
| } | ||
|
|
||
| trunc := id[:maxLen] | ||
| trunc := id[:idLen] | ||
| result, err := s.e.Search(types.Hash256(trunc)) |
There was a problem hiding this comment.
I'd probably make the search term a string instead since you have to support prefixed keys too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the search endpoint to see if a v2 contract with the specified ID or a host with the specified pubkey exists. Ed25519 pubkeys and Hash256 values are both 32 bytes and we already strip prefixes on /search/:id so this works out.
Also, we now use errors that make more sense on the search endpoint. Previously we would just 500 on all errors. Now: