Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data hosting #89

Merged
merged 33 commits into from
Sep 19, 2017
Merged

Data hosting #89

merged 33 commits into from
Sep 19, 2017

Conversation

DavidLP
Copy link
Collaborator

@DavidLP DavidLP commented Sep 19, 2017

The amount of data needed for unit tests and the examples makes the git project unnecessary large (#55). Also in view of a PyPI release this had to be fixed.
Therefore all unit tests fixtures and examples data are now loaded on the fly from an ownCloud service called sciebo that is hosted by several universities in Germany. The data is in a public folder, write access can be given on demand.
The disadvantage is that other branches with different test data need the data also hosted there.
I still think that is the best solution for now and we should use the additional storage for some more demanding MIMOSA+FEI4 telescope examples.

@DavidLP DavidLP requested a review from laborleben September 19, 2017 15:02
@DavidLP DavidLP changed the title Data hosting addressing #55 Data hosting Sep 19, 2017
@laborleben
Copy link
Collaborator

That was quite a bit of work :-) I let CI finish the job and then sign off.

@DavidLP
Copy link
Collaborator Author

DavidLP commented Sep 19, 2017

Yes ;-) Especially since I implemented another cloud service that we do not use now... Nevertheless most changes are in the unittests, productive code is untouched,

@themperek
Copy link
Member

Maybe use release folder of github?

https://help.github.com/articles/about-releases/

@DavidLP
Copy link
Collaborator Author

DavidLP commented Sep 19, 2017

@themperek That might be a good idea for releases! I do not see how this helps us for development

@themperek
Copy link
Member

Can keep some versioning that will hold across branches and history.

@DavidLP DavidLP merged commit 69544e8 into development Sep 19, 2017
@DavidLP DavidLP deleted the data_hosting branch September 19, 2017 15:50
@DavidLP
Copy link
Collaborator Author

DavidLP commented Sep 19, 2017

I also do not like do have no versioning for the test files now. But we still implement features too frequently that dumping (often changing) binary data in (not existing) releases would help now.

@laborleben
Copy link
Collaborator

You have a hash value that points you to the right test data. In my opinion this cannot be better. It is just consuming lots of space after some time when the files are updated frequently.
If you go back in time and you will always find the proper test data? Do I get this right?

@DavidLP
Copy link
Collaborator Author

DavidLP commented Sep 19, 2017

You mean if sciebo does this? I do not think that it works like this. A public folder is nothing else than a not easy to guess link. The link is the secret. If the data changes the link should stay the same.

@laborleben
Copy link
Collaborator

Not easy to guess link -> some hash/random value. This is exactly what I meant.

OK, but this is bad. Any possibility to keep the old files available for downloading? Otherwise we cannot go back in time and run the tests. Not that I want to go back in time ;-)

@DavidLP
Copy link
Collaborator Author

DavidLP commented Sep 19, 2017

Any possibility to keep the old files available for downloading?

Well, I could just never delete them...

Until we have releases and we add the data to the release I think that is ok.
Downloading data from github can be done without changing to much code.

Let go into the future and forget the past :-;

@DavidLP DavidLP mentioned this pull request Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants