Correcting typo in instructions for making tree-sitter support #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions had `./src/scanner.cc` on the second line (i.e. an extra `c` in the file extension) which I have corrected. At the same time I've... + Moved the instructions from a list to code blocks and changed to sub-headings. + Moved comment in brackets about `/path/to/tree-sitter-langs` to the start of the section and included a link to the package. + Changed instruction for installation to be added to `init.el` rather than `.emacs` as this is the more common location (often `init.el` is nested within a `.emacs` directory). + Added instructions for installing and configuring with `use-package`.
|
Hey @ShuguangSun thanks for accepting and merging my PR. Would you mind tagging this with this with the label Noticed the CI was failing and have created an issue but am unsure how to address that as well as making another PR to add support for CI testing on Emacs 29.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions had
./src/scanner.ccon the second line (i.e. an extracin the file extension) which I have corrected.At the same time I've...
/path/to/tree-sitter-langsto the start of the section and included a link to the package.init.elrather than.emacsas this is the more common location (ofteninit.elis nested within a.emacsdirectory).use-package.