Fix #144 for CryoFuels #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryoFuels seems to allow multiple cryogenic fuels in a module now and the old FuelName property of the module is no longer being set correctly. Instead get it from the individual fuels item.
|
This is a fix for #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the FuelName property on the module itself isn't being set correctly anymore and instead CryoFuels supports potentially multiple fuels at once inside of a private
fuelsfield. This now iterates through the fuels list and fetches the fuelName (and boil-off rate) from each fuel.I also changed Lib.PrivateField to allow value types instead of just reference types.