Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more H2 and O2 dumping during electrolysis #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

basilicofresco
Copy link

When hydrogen or oxygen tanks are full now the electrolysis should stop in order to avoid unnecessary water disintegration.

When hydrogen or oxygen tanks are full now the electrolysis should stop in order to avoid unnecessary water disintegration.
@lordcirth
Copy link

This is an interesting question. The user-desired behaviour depends on why they are running electrolysis. If they are trying to store EC by splitting water in fuel for a fuel cell, they don't want to dump either one. If they are trying to convert water into oxygen to breathe, they may not even have hydrogen storage, and this patch would prevent this use case. Is it possible to set hydrogen to dump, and oxygen to not dump?

@basilicofresco
Copy link
Author

Well, you are right. In order to discard hydrogen when there is no left space you just have to write "dump = hydrogen" instead of "dump = false".

At this point I wonder if two different electrolysis processes could be useful. Just imagine:

  • Water Electrolysis --> Split Water into its Hydrogen and Oxygen components.
  • Water Electrolysis (oxygen priority) --> Split Water into its Hydrogen and Oxygen components. If necessary Hydrogen will be vented in order to continue the Oxygen extraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants