Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test stub for token exchange auth #1897

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add test stub for token exchange auth #1897

merged 1 commit into from
Aug 22, 2024

Conversation

zzooeeyy
Copy link
Contributor

What this PR does

Fixes this issue:

We were missing a test stub for token exchange because we introduced a new helper in ShopifyAPI::Utils::SessionUtils for session_id_from_shopify_id_token, used in Token Exchange

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@zzooeeyy zzooeeyy requested a review from a team as a code owner August 19, 2024 19:31
@paulomarg paulomarg merged commit 8221012 into main Aug 22, 2024
7 checks passed
@paulomarg paulomarg deleted the zoey/fix-test branch August 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants