Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configuration flag for token exchange #1778

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

zzooeeyy
Copy link
Contributor

For

What this PR does

  • Add new configuration flag to enable token exchange workflow
  • We'll need to rename wip_token_exchange configuration once it's ready to be used.

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • [NA] Update CHANGELOG.md if the changes would impact users
  • [NA] Update README.md, if appropriate.
  • [NA] Update any relevant pages in /docs, if necessary
  • [NA] For security fixes, the Disclosure Policy must be followed.

@zzooeeyy zzooeeyy force-pushed the add-token-exchange-config branch from 641e2aa to 20e3f75 Compare January 15, 2024 22:28
@zzooeeyy zzooeeyy force-pushed the add-token-exchange-config branch from 20e3f75 to 1bd9bb0 Compare January 17, 2024 22:43
@zzooeeyy zzooeeyy marked this pull request as ready for review January 17, 2024 22:50
@zzooeeyy zzooeeyy requested a review from a team as a code owner January 17, 2024 22:50
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, though I don't love the wip in the config name. Could we say unstable instead?

Also, I assume the actual functionality will come later? 😄

@zzooeeyy
Copy link
Contributor Author

Works for me, though I don't love the wip in the config name. Could we say unstable instead?
Also, I assume the actual functionality will come later? 😄

Yes, actual functionality will come later, that's why I'm inclined to name it "wip" since it's actually "work in progress", "unstable" to me means something that's already implemented and it's partially working, just unstable..

@zzooeeyy zzooeeyy merged commit 80db41e into main Jan 18, 2024
8 checks passed
@zzooeeyy zzooeeyy deleted the add-token-exchange-config branch January 18, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants