Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrasing GDPR terminology in Shopify/shopify_app #1737

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Rephrasing GDPR terminology in Shopify/shopify_app #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/shopify_app/webhooks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#### Table of contents

[Manage webhooks using `ShopifyApp::WebhooksManager`](#manage-webhooks-using-shopifyappwebhooksmanager)
[Mandatory GDPR Webhooks](#mandatory-gdpr-webhooks)
[Mandatory Privacy Webhooks](#mandatory-privacy-webhooks)

## Manage webhooks using `ShopifyApp::WebhooksManager`

Expand Down Expand Up @@ -72,9 +72,9 @@ rails g shopify_app:add_webhook --topic carts/update --path webhooks/carts_updat

Where `--topic` is the topic and `--path` is the path the webhook should be sent to.

## Mandatory GDPR Webhooks
## Mandatory Privacy Webhooks

We have three mandatory GDPR webhooks
We have three mandatory privacy webhooks

1. `customers/data_request`
2. `customer/redact`
Expand Down
2 changes: 1 addition & 1 deletion .../add_gdpr_jobs/add_gdpr_jobs_generator.rb → ...rivacy_jobs/add_privacy_jobs_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

module ShopifyApp
module Generators
class AddGdprJobsGenerator < Rails::Generators::Base
class AddPrivacyJobsGenerator < Rails::Generators::Base
source_root File.expand_path("../templates", __FILE__)

def add_customer_data_request_job
Expand Down
0 ...emplates/customers_data_request_job.rb.tt → ...emplates/customers_data_request_job.rb.tt
View file
Open in desktop
File renamed without changes.
0 ...jobs/templates/customers_redact_job.rb.tt → ...jobs/templates/customers_redact_job.rb.tt
View file
Open in desktop
File renamed without changes.
0 ...gdpr_jobs/templates/shop_redact_job.rb.tt → ...vacy_jobs/templates/shop_redact_job.rb.tt
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion lib/generators/shopify_app/shopify_app_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def initialize(args, *options)

def run_all_generators
generate("shopify_app:add_app_uninstalled_job")
generate("shopify_app:add_gdpr_jobs")
generate("shopify_app:add_privacy_jobs")
generate("shopify_app:install #{@opts.join(" ")}")
generate("shopify_app:shop_model #{@opts.join(" ")}")
generate("shopify_app:authenticated_controller")
Expand Down
6 changes: 3 additions & 3 deletions ...ators/add_gdpr_jobs_generator_job_test.rb → ...rs/add_privacy_jobs_generator_job_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# frozen_string_literal: true

require "test_helper"
require "generators/shopify_app/add_gdpr_jobs/add_gdpr_jobs_generator"
require "generators/shopify_app/add_privacy_jobs/add_privacy_jobs_generator"

class AddGdprJobsGeneratorJobTest < Rails::Generators::TestCase
tests ShopifyApp::Generators::AddGdprJobsGenerator
class AddPrivacyJobsGeneratorJobTest < Rails::Generators::TestCase
tests ShopifyApp::Generators::AddPrivacyJobsGenerator
destination File.expand_path("../tmp", File.dirname(__FILE__))

setup do
Expand Down
Loading