Skip to content

Commit

Permalink
Rephrasing GDPR terminology in Shopify/shopify_app
Browse files Browse the repository at this point in the history
  • Loading branch information
local-administrator committed Oct 25, 2023
1 parent 23bb276 commit 3e069d6
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions docs/shopify_app/webhooks.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#### Table of contents

[Manage webhooks using `ShopifyApp::WebhooksManager`](#manage-webhooks-using-shopifyappwebhooksmanager)
[Mandatory GDPR Webhooks](#mandatory-gdpr-webhooks)
[Mandatory Privacy Webhooks](#mandatory-privacy-webhooks)

## Manage webhooks using `ShopifyApp::WebhooksManager`

Expand Down Expand Up @@ -72,9 +72,9 @@ rails g shopify_app:add_webhook --topic carts/update --path webhooks/carts_updat

Where `--topic` is the topic and `--path` is the path the webhook should be sent to.

## Mandatory GDPR Webhooks
## Mandatory Privacy Webhooks

We have three mandatory GDPR webhooks
We have three mandatory privacy webhooks

1. `customers/data_request`
2. `customer/redact`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

module ShopifyApp
module Generators
class AddGdprJobsGenerator < Rails::Generators::Base
class AddPrivacyJobsGenerator < Rails::Generators::Base
source_root File.expand_path("../templates", __FILE__)

def add_customer_data_request_job
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/shopify_app/shopify_app_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def initialize(args, *options)

def run_all_generators
generate("shopify_app:add_app_uninstalled_job")
generate("shopify_app:add_gdpr_jobs")
generate("shopify_app:add_privacy_jobs")
generate("shopify_app:install #{@opts.join(" ")}")
generate("shopify_app:shop_model #{@opts.join(" ")}")
generate("shopify_app:authenticated_controller")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# frozen_string_literal: true

require "test_helper"
require "generators/shopify_app/add_gdpr_jobs/add_gdpr_jobs_generator"
require "generators/shopify_app/add_privacy_jobs/add_privacy_jobs_generator"

class AddGdprJobsGeneratorJobTest < Rails::Generators::TestCase
tests ShopifyApp::Generators::AddGdprJobsGenerator
class AddPrivacyJobsGeneratorJobTest < Rails::Generators::TestCase
tests ShopifyApp::Generators::AddPrivacyJobsGenerator
destination File.expand_path("../tmp", File.dirname(__FILE__))

setup do
Expand Down

0 comments on commit 3e069d6

Please sign in to comment.