Skip to content

Commit

Permalink
Merge pull request #480 from Shopify/gdpr-rephrase
Browse files Browse the repository at this point in the history
Rephrasing GDPR terminology in Shopify/shopify-app-template-php
  • Loading branch information
local-administrator authored Nov 15, 2023
2 parents f3d8e9f + 56d042d commit cd69620
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@

declare(strict_types=1);

namespace App\Lib\Handlers\Gdpr;
namespace App\Lib\Handlers\Privacy;

use Illuminate\Support\Facades\Log;
use Shopify\Webhooks\Handler;

/**
* Customers can request their data from a store owner. When this happens,
* Shopify invokes this webhook.
* Shopify invokes this privacy webhook.
*
* https://shopify.dev/docs/apps/webhooks/configuration/mandatory-webhooks#customers-data_request
*/
class CustomersDataRequest implements Handler
{
public function handle(string $topic, string $shop, array $body): void
{
Log::debug("Handling GDPR customer data request for $shop");
Log::debug("Handling customer data request for $shop");
// Payload has the following shape:
// {
// "shop_id": 954889,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@

declare(strict_types=1);

namespace App\Lib\Handlers\Gdpr;
namespace App\Lib\Handlers\Privacy;

use Illuminate\Support\Facades\Log;
use Shopify\Webhooks\Handler;

/**
* Store owners can request that data is deleted on behalf of a customer. When
* this happens, Shopify invokes this webhook.
* this happens, Shopify invokes this privacy webhook.
*
* https://shopify.dev/docs/apps/webhooks/configuration/mandatory-webhooks#customers-redact
*/
class CustomersRedact implements Handler
{
public function handle(string $topic, string $shop, array $body): void
{
Log::debug("Handling GDPR customer redaction request for $shop");
Log::debug("Handling customer redaction request for $shop");
// Payload has the following shape:
// {
// "shop_id": 954889,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

declare(strict_types=1);

namespace App\Lib\Handlers\Gdpr;
namespace App\Lib\Handlers\Privacy;

use Illuminate\Support\Facades\Log;
use Shopify\Webhooks\Handler;

/**
* 48 hours after a store owner uninstalls your app, Shopify invokes this
* 48 hours after a store owner uninstalls your app, Shopify invokes this privacy
* webhook.
*
* https://shopify.dev/docs/apps/webhooks/configuration/mandatory-webhooks#shop-redact
Expand All @@ -17,7 +17,7 @@ class ShopRedact implements Handler
{
public function handle(string $topic, string $shop, array $body): void
{
Log::debug("Handling GDPR shop redaction request for $shop");
Log::debug("Handling shop redaction request for $shop");
// Payload has the following shape:
// {
// "shop_id": 954889,
Expand Down
10 changes: 5 additions & 5 deletions web/app/Providers/AppServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

use App\Lib\DbSessionStorage;
use App\Lib\Handlers\AppUninstalled;
use App\Lib\Handlers\Gdpr\CustomersDataRequest;
use App\Lib\Handlers\Gdpr\CustomersRedact;
use App\Lib\Handlers\Gdpr\ShopRedact;
use App\Lib\Handlers\Privacy\CustomersDataRequest;
use App\Lib\Handlers\Privacy\CustomersRedact;
use App\Lib\Handlers\Privacy\ShopRedact;
use Illuminate\Support\ServiceProvider;
use Illuminate\Support\Facades\URL;
use Shopify\Context;
Expand Down Expand Up @@ -58,8 +58,8 @@ public function boot()
Registry::addHandler(Topics::APP_UNINSTALLED, new AppUninstalled());

/*
* This sets up the mandatory GDPR webhooks. You’ll need to fill in the endpoint to be used by your app in the
* “GDPR mandatory webhooks” section in the “App setup” tab, and customize the code when you store customer data
* This sets up the mandatory privacy webhooks. You’ll need to fill in the endpoint to be used by your app in
* the “Privacy webhooks” section in the “App setup” tab, and customize the code when you store customer data
* in the handlers being registered below.
*
* More details can be found on shopify.dev:
Expand Down

0 comments on commit cd69620

Please sign in to comment.