Skip to content

Commit

Permalink
Remove references to --skip-dry-run flag, update CHANGELOG and version
Browse files Browse the repository at this point in the history
  • Loading branch information
timothysmith0609 committed Jan 30, 2024
1 parent 8c2c315 commit 391b5af
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
## next

# 3.4.2

- Remove flag `--skip-dry-run` (see [#946](https://github.com/Shopify/krane/pull/946))
- Remove support for batched server-side dry-run ([#946](https://github.com/Shopify/krane/pull/946))

# 3.4.1

- Added flag `--skip-dry-run` to completely opt out of dry run validation.
- Added flag `--skip-dry-run` to completely opt out of dry run validation.

# 3.4.0

Expand Down
2 changes: 0 additions & 2 deletions lib/krane/cli/deploy_command.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ class DeployCommand
default: false },
"verify-result" => { type: :boolean, default: true,
desc: "Verify workloads correctly deployed" },
"skip-dry-run" => { type: :boolean, desc: "Enable skipping dry run", default: false},
}

def self.from_options(namespace, context, options)
Expand Down Expand Up @@ -72,7 +71,6 @@ def self.from_options(namespace, context, options)
selector: selector,
selector_as_filter: selector_as_filter,
protected_namespaces: protected_namespaces,
skip_dry_run: options["skip-dry-run"]
)

deploy.run!(
Expand Down
2 changes: 1 addition & 1 deletion lib/krane/version.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# frozen_string_literal: true
module Krane
VERSION = "3.4.1"
VERSION = "3.4.2"
end

0 comments on commit 391b5af

Please sign in to comment.