Continue other jobs on Rails edge failures #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails edge (and Ruby HEAD, but we always combine that with Rails edge) is a moving target out of our control. Therefore, if a failure occurs on a job testing against it, it is useful to let the other jobs continue, as that helps narrow down if the failure is due to a change made there.
sambostock
force-pushed
the
continue-on-ruby-head-error
branch
from
ba4ee80 to
120f17a
Compare
|
CI failures on Ruby HEAD are expected. See steveklabnik/mono_logger#12. |
Mangara
approved these changes
Feb 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails edge (and Ruby HEAD, but we always combine that with Rails edge) is a moving target out of our control. Therefore, if a failure occurs on a job testing against it, it is useful to let the other jobs continue, as that helps narrow down if the failure is due to a change made there.
I noticed that CI was failing on #81, but couldn't tell if it was isolated to edge versions because the jobs would get cancelled. Sure enough, it looks like something has broken upstream.