Investigate using ActiveJob::Serializers to serialize cursor
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.0 of the gem will forbid cursors that are not (de)serializable using built in types. This is because adapters serialize to JSON, and we must ensure this is possible in a lossless fashion. Ahead of this change, we introduce a deprecation warning, as well as a configuration which makes it possible to enable the strict behavior. This configuration can be set globally, and/or at the job level. For instance, it is possible to enable it globally, but disable it for a jobs that have yet to be migrated, or alternatively to enable it for jobs that are already compliant, but leave it disabled globally to allow for non-compliant jobs. In theory, any non-compliant jobs are "already broken", however it is possible that the job works around the "bug" in (de)serialization. One known scenario is where jobs complete rapidly enough to never actually require cursor serialization, and as such never actually encounter the problem of un(de)serializable cursors in production environments. However, this could technically occur at any time.
Co-authored-by: Sander Verdonschot <[email protected]>
...rather than restrict cursors to simple types.
sambostock
force-pushed
the
active-job-serializer-cursor
branch
from
fb20f1d to
9c6a99f
Compare
sambostock
changed the title
ActiveModel::Serializers to serialize cursorActiveJob::Serializers to serialize cursor
bdewater
reviewed
Jul 15, 2022
Mangara
reviewed
Jul 18, 2022
|
Cool. I'll integrate this work into the other branch. 👍 |
sambostock
force-pushed
the
deprecate-unsafe-cursors
branch
from
8186aad to
eb2859f
Compare
|
Closing in favour of #81, as these changes have been integrated into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This investigates an alternate approach to #81, as suggested by @bdewater.
If this approach makes sense, #81 will be updated and this PR will be closed.
If not, then it will also be closed.