Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_until_version test helper #150

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

sambostock
Copy link
Contributor

@sambostock sambostock commented Nov 13, 2021

This helper will skip the test ONLY if the gem version is below the specified version.

This ensures that changes meant for a particular version release are included, and not forgotten or otherwise missed. If the gem version is bumped to the specified version or more, the tests will not be skipped, forcing the behaviour to be implemented, or explicitly further deferred.

Specifically, we have a number of breaking changes queued up which we want to make sure to release together in v2.0.0, including:

⚠️ Before Merging

@sambostock sambostock force-pushed the add-skip-until-version-test-helper branch from 63fcddf to f4917a7 Compare November 13, 2021 19:55
This helper will skip the test ONLY if the gem version is below the
specified version.

This ensures that changes meant for a particular version release are
included, and not forgotten or otherwise missed.
@sambostock sambostock force-pushed the add-skip-until-version-test-helper branch from f4917a7 to d3fdeff Compare November 15, 2021 15:35
@sambostock sambostock merged commit 6c24c05 into master Nov 15, 2021
@sambostock sambostock deleted the add-skip-until-version-test-helper branch November 15, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants