-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Improved the Dashing gh-page navigation #384
base: gh-pages
Are you sure you want to change the base?
Conversation
- Using same titles as in navigation - Moved demo into buttons - Listing the widgets (finding built-in and 3rd party wigets was hard to find)
@@ -214,6 +214,23 @@ <h3 class="section-title">Getting Data Into Your Widgets</h3> | |||
|
|||
<script src="https://gist.github.com/davefp/6112780.js?file=curl2.sh"></script> | |||
|
|||
<h4>Widgets</h4> | |||
|
|||
<p>Dashing comes with few re-usable widgets (reminder: <i>data-view="WidgetName"</i> in dashboard defines the used widget): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, this should read:
Dashing comes with a few re-usable widgets, which can be used as indicated above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. I surely can update the PR - assumed no one was interested merging it (as this is almost year old)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I am going through all the old PRs and trying to triage it a bit for the maintainer(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I wasn't implying you had to be the one to make the updates -- just that these are the updates I recommend. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm pretty much fine with any additional change (while still holding the original idea of three items mentioned in PR). So go ahead, you have my blessing 👍
The changes can be viewed here: http://juhamust.github.io/dashing/ Overall, I like these changes. My only gripe is with the Widgets section that was added to the bottom of My suggestion is:
|
I always struggle to find the wanted information from Dashing pages - especially the widgets. This pull request tries to improve the structure/situation.