Remove Autoredirect by Default in Remote Viewer #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianleshopify
force-pushed
the
brianle/remove_autoredirect_in_remove_viewer
branch
from
638082f
to
74a0b39
Compare
brianleshopify
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
I work on GraphiQL within Services Internal in my spare time and noticed that profiling doesn’t seem to work in dev environments while it does in prod.
I found the root of this is because in Dev the profiler returns an HTTP redirect
Decided to make the auto redirect rely on the
autoredirectparam and to place the link toAppProfiler.profiler_headerinstead.Open questions:
It seems like this behaviour exists to some an extent in the UploadAction is there any reason why we can't use this instead