Use viewing in test mode by default

Uploading in test mode doesn't really make sense, unless you're using CI maybe, but in that case it can be overridden.
Shopify · Dec 7, 2023 · 571f36e · 571f36e
1 parent 641f562
commit 571f36e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -306,7 +306,7 @@ AppProfiler.storage.credentials = { "key" => "value" }
 Rails.application.config.app_profiler.storage_credentials = { "key" => "value" }
 ```
 
-Note that in `development` mode the file isn't uploaded. Instead, it is viewed via the `Middleware::ViewAction`. If you want to change that, use the `middleware_action` configuration:
+Note that in `development` and `test` modes the file isn't uploaded. Instead, it is viewed via the `Middleware::ViewAction`. If you want to change that, use the `middleware_action` configuration:
 
 ```ruby
 Rails.application.config.app_profiler.middleware_action = AppProfiler::Middleware::UploadAction

diff --git a/lib/app_profiler/railtie.rb b/lib/app_profiler/railtie.rb
@@ -63,7 +63,7 @@ class Railtie < Rails::Railtie
     private
 
     def default_middleware_action
-      if Rails.env.development?
+      if Rails.env.development? || Rails.env.test?
         Middleware::ViewAction
       else
         Middleware::UploadAction