Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default timeout to 60s #218

Merged
merged 1 commit into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

### [1.0.6]

### Changes

* update default timeout to 60s

### [1.0.5](https://www.github.com/ShipEngine/shipengine-js/compare/v1.0.4...v1.0.5) (2023-07-10)


Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export interface ShipEngineConfig {
* The maximum amount of time (in milliseconds) to wait for a response from
* the ShipEngine server.
*
* Defaults to 5000 (5 seconds).
* Defaults to 60000 (60 seconds).
*/
timeout?: number;
}
Expand Down
2 changes: 1 addition & 1 deletion karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module.exports = (cfg) => {

client: {
mocha: {
timeout: 6000, // 6 seconds - upped from 2 seconds
timeout: 60000, // 60 seconds - upped from 2 seconds
},
},

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "shipengine",
"version": "1.0.5",
"version": "1.0.6",
"description": "The official ShipEngine JavaScript SDK for Node.js",
"keywords": [
"shipengine",
Expand Down
Loading