added step to other loggers

ShashankMosaicML · Feb 3, 2024 · ae892f5 · ae892f5
1 parent 1627634
commit ae892f5
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 5 deletions.
diff --git a/composer/loggers/cometml_logger.py b/composer/loggers/cometml_logger.py
@@ -98,7 +98,8 @@ def init(self, state: State, logger: Logger) -> None:
             assert self.experiment is not None
             self.experiment.set_name(self.name)
 
-    def log_table(self, columns: List[str], rows: List[List[Any]], name: str = 'Table') -> None:
+    def log_table(self, columns: List[str], rows: List[List[Any]], name: str = 'Table', step: Optional[int] = None) -> None:
+        del step
         if self._enabled:
             assert self.experiment is not None
             try:

diff --git a/composer/loggers/console_logger.py b/composer/loggers/console_logger.py
@@ -77,7 +77,8 @@ def log_hyperparameters(self, hyperparameters: Dict[str, Any]):
         # Lazy logging of hyperparameters.
         self.hparams.update(hyperparameters)
 
-    def log_table(self, columns: List[str], rows: List[List[Any]], name: str = 'Table') -> None:
+    def log_table(self, columns: List[str], rows: List[List[Any]], name: str = 'Table', step: Optional[int] = None) -> None:
+        del step
         try:
             import pandas as pd
         except ImportError as e:

diff --git a/composer/loggers/file_logger.py b/composer/loggers/file_logger.py
@@ -185,7 +185,8 @@ def log_traces(self, traces: Dict[str, Any]):
                     trace_str + '\n',
                 )
 
-    def log_table(self, columns: List[str], rows: List[List[Any]], name: str = 'Table') -> None:
+    def log_table(self, columns: List[str], rows: List[List[Any]], name: str = 'Table', step: Optional[int] = None) -> None:
+        del step
         try:
             import pandas as pd
         except ImportError as e:

diff --git a/composer/loggers/in_memory_logger.py b/composer/loggers/in_memory_logger.py
@@ -72,7 +72,8 @@ def __init__(self) -> None:
     def log_hyperparameters(self, hyperparameters: Dict[str, Any]):
         self.hyperparameters.update(hyperparameters)
 
-    def log_table(self, columns: List[str], rows: List[List[Any]], name: str = 'Table') -> None:
+    def log_table(self, columns: List[str], rows: List[List[Any]], name: str = 'Table', step: Optional[int] = None) -> None:
+        del step
         try:
             import pandas as pd
         except ImportError as e:

diff --git a/composer/loggers/mlflow_logger.py b/composer/loggers/mlflow_logger.py
@@ -182,7 +182,8 @@ def init(self, state: State, logger: Logger) -> None:
     def after_load(self, state: State, logger: Logger) -> None:
         logger.log_hyperparameters({'mlflow_experiment_id': self._experiment_id, 'mlflow_run_id': self._run_id})
 
-    def log_table(self, columns: List[str], rows: List[List[Any]], name: str = 'Table') -> None:
+    def log_table(self, columns: List[str], rows: List[List[Any]], name: str = 'Table', step: Optional[int] = None) -> None:
+        del step
         if self._enabled:
             try:
                 import pandas as pd