fixed analysis issues and added support for dart 3 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcishED
approved these changes
Aug 25, 2023
ShadyBoukhary
requested changes
Aug 25, 2023
| @@ -132,8 +132,8 @@ abstract class BackgroundUseCase<T, Params> extends UseCase<T, Params> { | |||
|
|
|||
| @override | |||
| @nonVirtual | |||
| Future<Stream<T?>> buildUseCaseStream(params) => | |||
| Future.value(Stream.value(null)); | |||
| Stream<T?> buildUseCaseStream(params) => | |||
| Function getUserOnNext; | ||
| Function getUserOnComplete; | ||
| Function getUserOnError; | ||
| Function? getUserOnNext; |
| @@ -26,7 +27,7 @@ class GetUserUseCase | |||
| // Trigger .onError | |||
| controller.addError(e); | |||
| } | |||
| return controller.stream; | |||
| yield* controller.stream; | |||
There was a problem hiding this comment.
Can you explain the remove of Futures and replacement with this syntax?
|
@masnun-siam did you mean to close this? I was going to check it in after the tests pass |
|
Sorry about not replying to the comments. Actually, it's been a while since I made the PR and when I saw your comments, I reviewed the changes I made but some of the lines didn't make sense to me either. I actually forgot why I made those changes at the first place. Also, it was one of my first PRs so I didn't check any of the tests before I made the PR so I wanted to close it and recreate it properly on my weekends if the issue still exists. |
|
Okay, feel free to create a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the analysis issues and added support for Dart 3
...